Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable CSI Driver Remote Install #52

Merged
merged 2 commits into from
Aug 2, 2022
Merged

Enable CSI Driver Remote Install #52

merged 2 commits into from
Aug 2, 2022

Conversation

vinli-cn
Copy link
Collaborator

What type of PR is this?
/kind feature

What this PR does / why we need it:
Enable remote install
Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 25, 2022
@k8s-ci-robot k8s-ci-robot requested a review from andyzhangx July 25, 2022 05:24
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 25, 2022
@coveralls
Copy link

coveralls commented Jul 25, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2737397039

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 78.134%
Totals Coverage Status
Change from base Build 2694829153: 0.0%
Covered Lines: 854
Relevant Lines: 1093
💛 - Coveralls

@vinli-cn
Copy link
Collaborator Author

The Trivy vulnerability scanner issue will be addressed by another PR

andyzhangx
andyzhangx approved these changes Aug 2, 2022
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@andyzhangx andyzhangx merged commit b2bc1d0 into kubernetes-sigs:main Aug 2, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 2, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, joe-atzinger, vinli-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 2, 2022
@vinli-cn vinli-cn mentioned this pull request Dec 7, 2022
Closed
9 tasks
joe-atzinger pushed a commit to joe-atzinger/azurelustre-csi-driver that referenced this pull request Jan 12, 2023
@vinli-cn
Enable CSI Driver Remote Install (kubernetes-sigs#52)
ac5c022 
* enable remote install

* update master to main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joe-atzinger joe-atzinger joe-atzinger approved these changes

@andyzhangx andyzhangx andyzhangx approved these changes

Assignees

@andyzhangx andyzhangx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vinli-cn @coveralls @k8s-ci-robot @andyzhangx @joe-atzinger @vinli-gh